Re: [RFC PATCH 1/6] leak fix: cache_put_path

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2023, 21:59 UTC
Message-ID: <xmqqilg352og.fsf@gitster.g>
In-Reply-To: <CAFySSZD9BZA9Qa5Z5KQymkowB9YtasUnNMehtA1feg43UsfwFw@mail.gmail.com>

Calvin Wan <calvinwan@google.com> writes:

Show 6 quoted lines

> If you look at t4027-diff-submodule.sh:git diff HEAD with dirty submodule
> (work tree, refs match) [.gitmodules], it's two different submodules
> pointing to the same path (or more precisely a second submodule is
> manually added to .gitmodules with a path to the first submodule). This
> is a setup that is not expected to happen commonly in real life so
> updating this test makes sense to me.

Thanks for double checking. If it is a configuration that is an error, then we would want to notice it eventually (probably outside the scope of this series), and before that happens, I agree that modifying the test to avoid such an errnoneous scenario would be a very good idea---otherwise we'd be pretending that such a scenario is a supported configuration somehow and misleading developers and users.

Thanks.