Re: Better suggestions when git-am(1) fails
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 13, 2023, 17:10 UTC
- Message-ID
- <xmqqpm9cwp9h.fsf@gitster.g>
- In-Reply-To
- <ZA9RYncZaqoA0mCw@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> On Fri, Mar 10, 2023 at 08:28:55AM -0800, Junio C Hamano wrote: > >> Jeff King <peff@peff.net> writes: >> >> > 1. I feel like "-p1" was pretty standard even before Git. You'd >> > extract two copies of the tarball, one into "foo-1.2.3" and one >> > into "foo-1.2.3.orig", and then "diff -Nru" between them to send a >> > patch. >> >> I would too, but then we wouldn't have accepted the request to add >> .noprefix configuration; I do not recall where it came from. > > I always thought it was an aesthetic thing for humans viewing diffs (and > likewise mnemonicprefix). The original thread doesn't give much > motivation, though: > > https://lore.kernel.org/git/1272852221-14927-1-git-send-email-eli@cloudera.com/
Interesting.
Comparison with mnemonicprefix is a bit unfair, as it does not break other tools, though ;-).