Re: [PATCH 5/5] format-patch: add format.noprefix option

From: Jeff King <peff@peff.net>
Date: Mar 10, 2023, 09:51 UTC
Message-ID: <ZAr9pcP8Ixuqwt51@coredump.intra.peff.net>
In-Reply-To: <xmqq5yb9dfn2.fsf@gitster.g>

On Thu, Mar 09, 2023 at 09:00:01AM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> But that is the other extreme.
> 
> I wonder if the consumer side should be made configurable for
> completeness, though.
> 
> Here is how "apply.pValue" configuration variable would look like.
> Projects whose members want diff.noprefix set can standardise on
> using that and then receiving end configured to match with this.

I don't mind this at all for the sake of completeness, and your patch looks reasonable to me. I mostly just wouldn't bother if there's not a demonstrated need (and again, this is something people could be asking for _now_, because of the way diff.noprefix works, and nobody has done so).

-Peff