git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision: Don't queue uninteresting commits

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 11, 2023, 16:40 UTC
Message-ID
<xmqqpm1lnme4.fsf@gitster.g>
In-Reply-To
<20231011123534.119994-1-oystwa@gmail.com>
Øystein Walle <oystwa@gmail.com> writes:
Show 5 quoted lines
> Currently all given commits are added to the topo_queue during
> init_topo_walk(). Later on in get_revision_1() the uninteresting ones
> are skipped because simplify_commit() tells it to.
>
> Let's not add them to the topo_queue in the first place.

What is not described here is what benefit we are expecting to gain by making this change. Is anything leaking? Are we showing wrong output? Is the effect something we can demonstrate, and more importantly we can protect from future breakages, with a test or two?

Previous: Øystein WalleNext: Øystein Walle
Message 2 of 3 in “revision: Don't queue uninteresting commits”
  1. revision: Don't queue uninteresting commitsØystein Walle, Oct 11, 2023
  2. Junio C HamanoOct 11, 2023
  3. Øystein WalleNov 6, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.