Re: [PATCH] revision: Don't queue uninteresting commits

From: Øystein Walle <oystwa@gmail.com>
Date: Nov 6, 2023, 11:28 UTC
Message-ID: <CAFaJEqtN0b+Prv79E2=sODaw8vRVGD-Ane7U+WzoFoTWkvCNkA@mail.gmail.com>
In-Reply-To: <xmqqpm1lnme4.fsf@gitster.g>

Hi, Junio, and sorry for the late response.

On Wed, 11 Oct 2023 at 18:40, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> What is not described here is what benefit we are expecting to gain
> by making this change.  Is anything leaking?  Are we showing wrong
> output?  Is the effect something we can demonstrate, and more
> importantly we can protect from future breakages, with a test or
> two?

As far as I know there is no significant benefit to this change. The only one I can think of is a case such as this:

    git rev-list some-rev ^a ^very ^large ^amount ^of ^negative ^revs ^here

but even then I would assume the work done by the algorithm in total is so large that the work saved by this change is insignificant.

I was just a bit happy after grokking a piece of this code and let the excitement get the best of me :-) I suggest we just drop it.

Øsse