Re: [PATCH 03/13] spaces and errors fix Handled git pipeline errors
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 14, 2023, 00:38 UTC
- Message-ID
- <xmqqpm0d2mpa.fsf@gitster.g>
- In-Reply-To
- <e31be0d764f47c21519016729259f8d74a53e21f.1699871056.git.gitgitgadget@gmail.com>
"Haritha D via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Subject: Re: [PATCH 03/13] spaces and errors fix Handled git pipeline errors
-ECANNOTPARSE. Perhaps Documentation/CodingGuidelines and Documentation/SubmittingPatches may help?
> From: Haritha D <harithamma.d@ibm.com> > > This PR has fixes to enable build on z/OS
This is way under-explained. Your proposed log message should be able to answer when somebody asks "Is anything broken in the existing codebase to cause your build to fail, or is it your compiler toolchain that is broken?" but the above does not help understanding what and why you needed to fix at all.
Show 23 quoted lines
> diff --git a/builtin/hash-object.c b/builtin/hash-object.c
> index b33b32ff977..9129658a37c 100644
> --- a/builtin/hash-object.c
> +++ b/builtin/hash-object.c
> @@ -62,8 +62,8 @@ static void hash_fd(int fd, const char *type, const char *path, unsigned flags,
> # include <stdio.h>
> # include <stdlib.h>
>
> - int setbinaryfd(int fd)
> - {
> +int setbinaryfd(int fd)
> +{
> attrib_t attr;
> int rc;
>
> @@ -74,7 +74,7 @@ static void hash_fd(int fd, const char *type, const char *path, unsigned flags,
>
> rc = __fchattr(fd, &attr, sizeof(attr));
> return rc;
> - }
> +}
> # endif
> #endifNo such function in our codebase. Are you fixing somebody else's forked version of Git and we shouldn't even be looking at this patch, perhaps?
Show 20 quoted lines
> diff --git a/convert.c b/convert.c
> index 4f14ff6f1ed..17cc849efed 100644
> --- a/convert.c
> +++ b/convert.c
> @@ -1315,15 +1315,28 @@ static struct attr_check *check;
>
> static const char* get_platform() {
> struct utsname uname_info;
> + char *result;
> + if(!uname_info.sysname)
> + {
> + result = (char *)malloc(strlen(uname_info.sysname)+1);
> + int index=0;
> + while(index <= strlen(uname_info.sysname))
> + {
> + *result = uname_info.sysname[index];
> + ++result;
> + ++index;
> + }
> + }No such function in our codebase. I doubt these patches have much relevance to this project?
I'll stop here.