git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/13] Enable builds for z/OS.

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 14, 2023, 01:47 UTC
Message-ID
<xmqqleb114xs.fsf@gitster.g>
In-Reply-To
<ZVKrWSv7JguKTSYw@tapette.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 19 quoted lines
> I'd generally want to look at the commit message and understand the
> problem the code is trying to solve and then look at the code and think,
> "Oh, yes, this seems like the obvious and logical way to solve this
> problem," or at least think, "Oh, no, I think we should solve this
> problem in a different way," so I can help make a thoughtful review
> comment.  Right now, I lack the information to have an informed opinion
> and so I can't provide any helpful feedback or analysis of the patches.
> ...
> I'd recommend a quick pass over the SubmittingPatches file, which is
> also available at https://git-scm.com/docs/SubmittingPatches.  The
> sections on making separate commits for separate changes and describing
> changes well come to mind as places to focus.
>
> I know this may seem overwhelming and like I'm upset or disappointed;
> I'm definitely not.  I'm very much interested in seeing Git available
> for more platforms, but right now it's too hard for me to reason about
> the changes for z/OS to provide helpful feedback, so I'm hoping you can
> send a fixed v2 that helps me (and everyone else) understand these
> changes better so you can get a helpful review.

All very good pieces of advice. I suspect we are missing some of them from our SubmittingPatches or CodingGuidelines documents and may want to add them there.

Thanks.
Previous: brian m. carlsonNext: Junio C Hamano
Message 10 of 21 in “Enabling z/OS workflow for git”
  1. 00/13 Enabling z/OS workflow for gitHaritha via GitGitGadget, Nov 13, 2023
  2. 01/13 Enabling z/OS workflow for gitHaritha D via GitGitGadget, Nov 13, 2023
  3. 03/13 spaces and errors fix Handled git pipeline errorsHaritha D via GitGitGadget, Nov 13, 2023
  4. Junio C HamanoNov 14, 2023
  5. 04/13 fixes for build errors Handled git pipeline errorseHaritha D via GitGitGadget, Nov 13, 2023
  6. 05/13 fixes for build errorsHaritha D via GitGitGadget, Nov 13, 2023
  7. 06/13 spaces and errors fix Handled git pipeline errorsHaritha D via GitGitGadget, Nov 13, 2023
  8. 02/13 Enable builds for z/OS.Haritha D via GitGitGadget, Nov 13, 2023
  9. brian m. carlsonNov 13, 2023
  10. Junio C HamanoNov 14, 2023
  11. Junio C HamanoNov 14, 2023
  12. 07/13 spaces and errors fix Handled git pipeline errorsHaritha D via GitGitGadget, Nov 13, 2023
  13. 08/13 platform_name fix Handled git pipeline errorsHaritha D via GitGitGadget, Nov 13, 2023
  14. 09/13 strncpy fix Handled git pipeline errorsHaritha D via GitGitGadget, Nov 13, 2023
  15. 10/13 strncpy fix Handled git pipeline errorsHaritha D via GitGitGadget, Nov 13, 2023
  16. 11/13 strncpy fix Handled git pipeline errorsHaritha D via GitGitGadget, Nov 13, 2023
  17. 12/13 Handled git pipeline errors - Memory leakHaritha D via GitGitGadget, Nov 13, 2023
  18. 13/13 Handled git pipeline errors - z/OS enableHaritha D via GitGitGadget, Nov 13, 2023
  19. This PR enables a successful git build on z/OS.Haritha via GitGitGadget, Dec 4, 2023
  20. Eric SunshineDec 4, 2023
  21. René ScharfeDec 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.