git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5] diff: add diff.srcPrefix and diff.dstPrefix configuration variables

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 18, 2024, 04:39 UTC
Message-ID
<xmqqplvskvbk.fsf@gitster.g>
In-Reply-To
<20240318034957.GA2935525@quokka>
Peter Hutterer <peter.hutterer@who-t.net> writes:
Show 29 quoted lines
> On Fri, Mar 15, 2024 at 10:57:22PM -0700, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > I am tempted to queue v4 with the z/ -> y/ fix from this round,
>> > without any other changes from v4 to v5.
>> 
>> So, that is what I did before I pushed out today's integration
>> result.  I however have an "after the dust settles" clean-up patch
>> on top (not committed yet), which I am sending out for review.
>> 
>> ------- >8 -------------- >8 -------------- >8 --------
>> Subject: diff.*Prefix: use camelCase in the doc and test titles
>> 
>> We added documentation for diff.srcPrefix and diff.dstPrefix with
>> their names properly camelCased, but the diff.noPrefix is listed
>> there in all lowercase.  Also these configuration variables, both
>> existing ones and the {src,dst}Prefix we recently added, were
>> spelled in all lowercase in the tests in t4013.
>> 
>> Now we are done with the main change, clean these up.
>> 
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
>
> And thanks for merging the patch!
>
> Cheers,
>   Peter
Thanks.
Previous: Peter Hutterer
Message 28 of 28 in “diff: add diff.srcprefix and diff.dstprefix option support”
  1. diff: add diff.srcprefix and diff.dstprefix option supportPeter Hutterer, Mar 11, 2024
  2. Junio C HamanoMar 11, 2024
  3. diff: add diff.srcprefix and diff.dstprefix configuration variablesPeter Hutterer, Mar 12, 2024
  4. Junio C HamanoMar 12, 2024
  5. Dragan SimicMar 12, 2024
  6. diff: add diff.srcPrefix and diff.dstPrefix configuration variablesPeter Hutterer, Mar 12, 2024
  7. Dragan SimicMar 13, 2024
  8. Dragan SimicMar 13, 2024
  9. Phillip WoodMar 13, 2024
  10. Dragan SimicMar 13, 2024
  11. Junio C HamanoMar 13, 2024
  12. Dragan SimicMar 13, 2024
  13. Phillip WoodMar 13, 2024
  14. Junio C HamanoMar 13, 2024
  15. Phillip WoodMar 13, 2024
  16. Junio C HamanoMar 13, 2024
  17. Peter HuttererMar 14, 2024
  18. Dragan SimicMar 13, 2024
  19. diff: add diff.srcPrefix and diff.dstPrefix configuration variablesPeter Hutterer, Mar 15, 2024
  20. Dragan SimicMar 15, 2024
  21. diff: add diff.srcPrefix and diff.dstPrefix configuration variablesPeter Hutterer, Mar 15, 2024
  22. Dragan SimicMar 15, 2024
  23. Junio C HamanoMar 15, 2024
  24. Dragan SimicMar 15, 2024
  25. Junio C HamanoMar 16, 2024
  26. Dragan SimicMar 16, 2024
  27. Peter HuttererMar 18, 2024
  28. Junio C HamanoMar 18, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.