Re: [PATCH v2] diff: add diff.srcprefix and diff.dstprefix configuration variables

From: Dragan Simic <dsimic@manjaro.org>
Date: Mar 12, 2024, 19:29 UTC
Message-ID: <2b2cdf7a3738f28ffc73ff10692361c5@manjaro.org>
In-Reply-To: <xmqq5xxrl0f9.fsf@gitster.g>

On 2024-03-12 20:23, Junio C Hamano wrote:

> Peter Hutterer <peter.hutterer@who-t.net> writes:
> 
>> Allow the default prefixes "a/" and "b/" to be tweaked by the
>> diff.srcprefix and diff.dstprefix configuration variables.

If I may interject, albeit a bit late, we should use "diff.srcPrefix" and "diff.dstPrefix" as the configuration option names.

Show 8 quoted lines

>> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
>> ---
>> Changes to v1:
>> - note default in documentation
>> - drop the custom prefix function, change the defaults instead
>> - commit message: options -> configuration variables
> 
> Looking good.  Will queue.  Thanks.