Re: [PATCH 05/22] upload-pack: fix leaking child process data on reachability checks

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2024, 22:30 UTC
Message-ID: <xmqqplppprsg.fsf@gitster.g>
In-Reply-To: <77023421e189aee6837cea9b25841ea258bc06e3.1724656120.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> We spawn a git-rev-list(1) command to perform reachability checks in
> "upload-pack.c". We do not release memory associated with the process
> in error cases though, thus leaking memory.

Thanks for plugging this leak dating back in ages.

Both changes look sensible to me.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.