Re: [PATCH 11/22] gpg-interface: fix misdesigned signing key interfaces
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 4, 2024, 22:09 UTC
- Message-ID
- <xmqqmskn6phb.fsf@gitster.g>
- In-Reply-To
- <a1fca8104b345bff4005fcd7e4c8edb67424fd20.1724656120.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> The interfaces to retrieve signing keys and their IDs are misdesigned as > they return string constants even though they indeed allocate memory, > which leads to memory leaks. Refactor the code to instead always return > allocated strings and let the callers free them accordingly.
Makes sense.