git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] completion: Make sed command that generates config-list.h portable.

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 3, 2025, 00:21 UTC
Message-ID
<xmqqplflsmic.fsf@gitster.g>
In-Reply-To
<e6a4b604-c5b7-450a-b4f5-3863441e0c6e@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 11 quoted lines
>> But we could put configurations on seperate lines like so:
>> 
>> ... 
>> -gitcvs.dbUser, gitcvs.dbPass::
>> +gitcvs.dbUser::
>> +gitcvs.dbPass::
>> ...
>> Then go back to the simpler sed expression before your most recent
>> commit. I will wait for others thoughts before posting v3.
>
> I like this approach.

As long as we warn our documenters that comma separated entries are forbidden in our documentation (even though AsciiDoc and Asciidoctor may allow them), it would be the simplest. The question is where.

Perhaps the tail end of the CodingGuidelines document where we already have write-up for markups?

Thanks.
Previous: Collin FunkNext: Collin Funk
Message 10 of 20 in “completion: Make sed command that generates config-list.h portable.”
  1. completion: Make sed command that generates config-list.h portable.Collin Funk, Jun 2, 2025
  2. Brad SmithJun 2, 2025
  3. Jean-Noël AVILAJun 2, 2025
  4. Collin FunkJun 2, 2025
  5. completion: Make sed command that generates config-list.h portable.Collin Funk, Jun 2, 2025
  6. Jean-Noël AVILAJun 2, 2025
  7. Collin FunkJun 2, 2025
  8. Jacob KellerJun 2, 2025
  9. Collin FunkJun 2, 2025
  10. Junio C HamanoJun 3, 2025
  11. CodingGuidelines: document formatting required by generate-configlist.sh.Collin Funk, Jun 3, 2025
  12. Junio C HamanoJun 3, 2025
  13. Collin FunkJun 3, 2025
  14. Junio C HamanoJun 3, 2025
  15. Collin FunkJun 3, 2025
  16. CodingGuidelines: document formatting of similar config variables.Collin Funk, Jun 3, 2025
  17. Junio C HamanoJun 3, 2025
  18. completion: make sed command that generates config-list.h portable.Collin Funk, Jun 2, 2025
  19. Keller, Jacob EJun 2, 2025
  20. Junio C HamanoJun 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.