git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH v3] completion: make sed command that generates config-list.h portable.

From
Keller, Jacob E <jacob.e.keller@intel.com>
Date
Jun 2, 2025, 23:05 UTC
Message-ID
<CO1PR11MB508935F77DB5D7CA29BF8D79D662A@CO1PR11MB5089.namprd11.prod.outlook.com>
In-Reply-To
<59b2a12a3f43cf078fbeaf0271b5a7cfffc9eb8f.1748903426.git.collin.funk1@gmail.com>
Show 27 quoted lines
> -----Original Message-----
> From: Collin Funk <collin.funk1@gmail.com>
> Sent: Monday, June 2, 2025 3:32 PM
> To: git@vger.kernel.org
> Cc: jn.avila@free.fr; Keller, Jacob E <jacob.e.keller@intel.com>; Collin Funk
> <collin.funk1@gmail.com>; Corentin Garcia <corenting@gmail.com>; Junio C
> Hamano <gitster@pobox.com>
> Subject: [PATCH v3] completion: make sed command that generates config-list.h
> portable.
> 
> The OpenBSD 'sed' command does not support '\n' to represent newlines in
> sed expressions. This leads to the follow compiler error:
> 
>     In file included from builtin/help.c:15:
>     ./config-list.h:282:18: error: use of undeclared identifier 'n'
>             "gitcvs.dbUser",n       "gitcvs.dbPass",
>                             ^
>     1 error generated.
>     gmake: *** [Makefile:2821: builtin/help.o] Error 1
> 
> We can fix this by documenting related configuration variables
> one-per-line instead of listing them separated by commas. This allows us
> to remove the unportable part of the sed expression in
> generate-configlist.sh.
> 
> Signed-off-by: Collin Funk <collin.funk1@gmail.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Previous: Collin FunkNext: Junio C Hamano
Message 19 of 20 in “completion: Make sed command that generates config-list.h portable.”
  1. completion: Make sed command that generates config-list.h portable.Collin Funk, Jun 2, 2025
  2. Brad SmithJun 2, 2025
  3. Jean-Noël AVILAJun 2, 2025
  4. Collin FunkJun 2, 2025
  5. completion: Make sed command that generates config-list.h portable.Collin Funk, Jun 2, 2025
  6. Jean-Noël AVILAJun 2, 2025
  7. Collin FunkJun 2, 2025
  8. Jacob KellerJun 2, 2025
  9. Collin FunkJun 2, 2025
  10. Junio C HamanoJun 3, 2025
  11. CodingGuidelines: document formatting required by generate-configlist.sh.Collin Funk, Jun 3, 2025
  12. Junio C HamanoJun 3, 2025
  13. Collin FunkJun 3, 2025
  14. Junio C HamanoJun 3, 2025
  15. Collin FunkJun 3, 2025
  16. CodingGuidelines: document formatting of similar config variables.Collin Funk, Jun 3, 2025
  17. Junio C HamanoJun 3, 2025
  18. completion: make sed command that generates config-list.h portable.Collin Funk, Jun 2, 2025
  19. Keller, Jacob EJun 2, 2025
  20. Junio C HamanoJun 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.