Re: [PATCH v7 0/4] support UTF-8 in alias names
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 19, 2026, 18:17 UTC
- Message-ID
- <xmqqpl6061k2.fsf@gitster.g>
- In-Reply-To
- <20260218215737.1181147-1-jonatan@jontes.page>
Jonatan Holmgren <jonatan@jontes.page> writes:
Show 13 quoted lines
> Hi all! > > This series adds support for non-alphanumeric (including UTF-8) > characters in alias names by allowing aliases to be defined using > git-config's subsection syntax. > > Changes since v6: > Reverted the --aliases-for-completion output format to > use a newline as the field separator between name and value within > each NUL-terminated record (name\nvalue\0). In v6 I changed this > to use NUL for both separators, but this diverges from the > convention established by git config -z, which outputs > key\nvalue\0. Matching that convention is the right call here.
OK. The key cannot have NUL nor LF in it, so either _should_ work, and using LF in the context of -z somehow makes our eyes feel dirty, but it is how "git config -z" chooses to work, so I agree that this change makes sense.
Shall we mark this topic ready for 'next' now?
Will queue. Thanks.