Re: [PATCH v2] pack-objects: trace pack bytes written
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 21, 2026, 03:33 UTC
- Message-ID
- <xmqqpkzcrvun.fsf@gitster.g>
- In-Reply-To
- <20260821004019.GA296407@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> Of course what I'd _really_ like to do is rip out --max-pack-size > entirely. I don't think it's generally helpful, and it introduces all > kinds of weird corner cases and complications like this. But obviously > that's a much bigger change, and naturally if I seriously proposed it > somebody would come out of the woodwork so with obscure case where it's > useful.
;-) Perhaps Git 3.0 boundary?
> I think this is a case where we could similarly relax. Especially > because this is just the pack checksum. The actual object contents are > still protected by their respective hashes.
Yes. Dropping the "(b) validate as we re-read" step is a reasonable thing to do with the least disruption from that viewpoint.
Thanks.