git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] pack-objects: trace pack bytes written

From
Jeff King <peff@peff.net>
Date
Aug 21, 2026, 00:47 UTC
Message-ID
<20260821004739.GA297273@coredump.intra.peff.net>
In-Reply-To
<c6a8cdac36d2202055d637ebcc97e484122cdcd4.1787158152.git.friel@openai.com>
On Wed, Aug 19, 2026 at 04:28:10PM -0700, friel@openai.com wrote:
Show 17 quoted lines
> From: Friel <friel@openai.com>
> 
> We want to measure how compression settings affect push performance on
> the client. Different settings can produce different-sized packs from
> the same objects. Trace2 records the object count, but we also need the
> pack size to compare those settings.
> 
> Add a write_pack_file/wrote_bytes Trace2 datum alongside
> write_pack_file/wrote. Count packs written to stdout or disk, including
> each pack's header and trailing checksum. When pack.packSizeLimit splits
> the output, report the sum of the pack sizes.
> 
> Signed-off-by: Friel <friel@openai.com>
> ---
> Junio, you're right. Updating bytes_written before finalization is
> equivalent. I've dropped pack_bytes; everything else is unchanged.
> Thanks.

The downthread discussion went pretty far off-topic, so for those who do not want to read it, the summary is: this patch looks good to me. ;)

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 11 in “pack-objects: trace pack bytes written”
  1. pack-objects: trace pack bytes writtenfriel@openai.com, Aug 17, 2026
  2. Junio C HamanoAug 18, 2026
  3. pack-objects: trace pack bytes writtenfriel@openai.com, Aug 19, 2026
  4. Patrick SteinhardtAug 20, 2026
  5. Jeff KingAug 20, 2026
  6. Patrick SteinhardtAug 20, 2026
  7. Jeff KingAug 21, 2026
  8. Junio C HamanoAug 21, 2026
  9. Junio C HamanoAug 20, 2026
  10. Jeff KingAug 21, 2026
  11. Junio C HamanoAug 21, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.