Re: [PATCH v2] fetch.c: defer fetch.followRemoteHEAD validation

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 30, 2026, 18:46 UTC
Message-ID: <xmqqpkxua87a.fsf@gitster.g>
In-Reply-To: <DLSD3JY380Q4.2VPO95D7M213G@lfurio.us>

"Matt Hunter" <m@lfurio.us> writes:

Show 9 quoted lines

> I agree with this assessment.  However, I wonder if Junio meant
>
>     We should (do something similar) to (what remote.c parses) ...
>
> instead of
>
>     We should do (something similar to what remote.c parses) ...
>
> as the issue in the NEEDSWORK _does_ apply to both sides.

Exactly.

> Perhaps at a minimum, this patch should leave the comment intact (or
> reworded) if not yet addressing remote.c.  v3 otherwise is looking good
> to me, and functionality seems to work.

To end users, the annoyance factor due to an irrelevant incorrect setting in fetch.followRemoteHEAD and remote.*.followRemoteHEAD variables killing their "git fetch" are the same. Correcting one may be better than correcting none, but until both gets corrected, we cannot claim we helped users.

Thanks.