Re: [PATCH v2] fetch.c: defer fetch.followRemoteHEAD validation

From: Colin Hinton <colinlewishinton@gmail.com>
Date: Oct 3, 2026, 04:50 UTC
Message-ID: <CAHeTm9MBx_ndL1XkdyjtjFaGvoF69AHwP6DLYsirpBVsiNRfAA@mail.gmail.com>
In-Reply-To: <xmqqpkxua87a.fsf@gitster.g>

Show 10 quoted lines

> > Perhaps at a minimum, this patch should leave the comment intact (or
> > reworded) if not yet addressing remote.c.  v3 otherwise is looking good
> > to me, and functionality seems to work.
>
> To end users, the annoyance factor due to an irrelevant incorrect
> setting in fetch.followRemoteHEAD and remote.*.followRemoteHEAD
> variables killing their "git fetch" are the same.  Correcting one
> may be better than correcting none, but until both gets corrected,
> we cannot claim we helped users.
>

All good points, I will add the NEEDSWORK back into this patch as this is a half measure to the entire problem; however, rather than leaving the NEEDSWORK in fetch.c, I will move it to remote.c near the remaining defect in handle_config(), and maybe add a short comment in fetch.c for context of this fix. Unless there are any concerns, V4 should be released soon.

-Colin Hinton