git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] read-cache: hide refresh_cache_entry()

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 30, 2026, 15:46 UTC
Message-ID
<xmqqpkwrxkbq.fsf@gitster.g>
In-Reply-To
<auRm0Ohkg3OQIbWE@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 7 quoted lines
>> Hide the low-level implementation detail again by making it a
>> file-scope static function.  The external callers would indirectly
>> call it when they call make_cache_entry() or rename_index_entry_at()
>> external interface, which "ort" (the successor of "recursive") does.
>
> Seeing all these patches dropping public declarations I wonder whether
> they should have been part of the same patch series :)
Perhaps ;-).
Show 7 quoted lines
>> +static struct cache_entry *refresh_cache_entry(struct index_state *, struct cache_entry *, unsigned int);
>> +
>>  static const char *alternate_index_output;
>>  
>>  static void set_index_entry(struct index_state *istate, int nr, struct cache_entry *ce)
>
> Could we avoid this forward declaration by moving the function around?

As refresh_cache_entry() that has mere one line in its body calls refresh_cache_ent() that is a screenful and defined nearby, both of them need to be moved upward, so it becomes a rather unsightly change, even though nobody would care when they only look at the end result X-<.

By the way, I tried "history fixup" to make this change, and noticed that the subcommand ignores "[notes] rewriteref = refs/notes/amlog", just like "git history reword" does. Again, I wonder if this is a known limitation, or a deliberate design.

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 3 of 5 in “read-cache: hide refresh_cache_entry()”
  1. read-cache: hide refresh_cache_entry()Junio C Hamano, Oct 28, 2026
  2. Patrick SteinhardtOct 30, 2026
  3. Junio C HamanoOct 30, 2026
  4. Patrick SteinhardtNov 2, 2026
  5. Junio C HamanoNov 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.