git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] read-cache: hide refresh_cache_entry()

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 2, 2026, 19:00 UTC
Message-ID
<xmqqld7bhxcm.fsf@gitster.g>
In-Reply-To
<auhbjFvD8CNXYcgQ@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 14 quoted lines
>> > Could we avoid this forward declaration by moving the function around?
>> 
>> As refresh_cache_entry() that has mere one line in its body calls
>> refresh_cache_ent() that is a screenful and defined nearby, both of
>> them need to be moved upward, so it becomes a rather unsightly
>> change, even though nobody would care when they only look at the end
>> result X-<.
>
> Well, people probably know by now that I myself tend to err more on the
> side of fixing up stuff, even if it's a bit more on the painful side of
> things. So I'm not going to surprise you by saying that I think that
> would be worth it.
>
> In any case, I don't feel strongly about it.

FWIW, the version with large code movement will be the final version, as my philosophy is "once written, unless there is a compelling reason, do not flip flop" and the last one I wrote was the one you suggested, so that I can see how bad the result looks.

I think the patch itself may be ugly but the result is easier to work on going forward. Thanks for pushing.

Previous: Patrick Steinhardt
Message 5 of 5 in “read-cache: hide refresh_cache_entry()”
  1. read-cache: hide refresh_cache_entry()Junio C Hamano, Oct 28, 2026
  2. Patrick SteinhardtOct 30, 2026
  3. Junio C HamanoOct 30, 2026
  4. Patrick SteinhardtNov 2, 2026
  5. Junio C HamanoNov 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.