Re: [PATCH v1 0/2] contrib/subtree: make it respect spaces in a repository path

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 4, 2015, 23:08 UTC
Message-ID: <xmqqoahheqax.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <cover.1441404851.git.Alex.Crezoff@gmail.com>

Alexey Shumkin <alex.crezoff@gmail.com> writes:

Show 8 quoted lines

> Some repositories may have spaces in their paths. Currently `git-subtree`
> raises an error in such cases.
> Also, `git-subtree` currently does not have tests for its 'push' command.
> Following patches are to fix these statements.
>
> Alexey Shumkin (2):
>   t7900-subtree: test the "space in a subdirectory name" case
>   contrib/subtree: respect spaces in a repository path

Doesn't this order break bisection? It seems that you turn "subdir" to "sub dir" in existing tests, and I understand that the whole point of this series is that such a change will expose that the tool is broken, making tests fail.

Also, if you feel up to it, it might be a good idea to clean t7900 test up to the current best practice before doing any other changes as a pure preparatory clean-up patch.

Namely, using cd outside a subshell of the tests to move around is a bad thing to do, and you are adding more instance of it in this series. If one test with such a cd to go down fails before it has a chance to come back up (or go up and then fail to come back down), the later tests will be left in an unexpected place.

>  contrib/subtree/git-subtree.sh     |   4 +-
>  contrib/subtree/t/t7900-subtree.sh | 194 +++++++++++++++++++++++--------------
>  2 files changed, 124 insertions(+), 74 deletions(-)

Thanks.