Re: [PATCH v1 0/2] contrib/subtree: make it respect spaces in a repository path

From: Alexey Shumkin <alex.crezoff@gmail.com>
Date: Sep 7, 2015, 11:05 UTC
Message-ID: <20150907110554.GA482@dell-note>
In-Reply-To: <xmqqoahheqax.fsf@gitster.mtv.corp.google.com>

On Fri, Sep 04, 2015 at 04:08:06PM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Alexey Shumkin <alex.crezoff@gmail.com> writes:
> 
> > Some repositories may have spaces in their paths. Currently `git-subtree`
> > raises an error in such cases.
> > Also, `git-subtree` currently does not have tests for its 'push' command.
> > Following patches are to fix these statements.
> >
> > Alexey Shumkin (2):
> >   t7900-subtree: test the "space in a subdirectory name" case
> >   contrib/subtree: respect spaces in a repository path
> 
> Doesn't this order break bisection?  It seems that you turn "subdir"
> to "sub dir" in existing tests, and I understand that the whole
> point of this series is that such a change will expose that the tool
> is broken, making tests fail.

It seems I have to reword commit messages to avoid such an interpretation. Because, the first commit does not break anything. It is to change the tests for `git-subtree` "to show" that `git-subtree`s already tested commands (almost) work correctly if there are spaces in paths (except --rejoin-msg issue). And the second commit adds missing tests and the fix. Should I add/commit the breaking test first and then commit the fix?

Show 10 quoted lines

> 
> Also, if you feel up to it, it might be a good idea to clean t7900
> test up to the current best practice before doing any other changes
> as a pure preparatory clean-up patch.
> 
> Namely, using cd outside a subshell of the tests to move around is a
> bad thing to do, and you are adding more instance of it in this
> series.  If one test with such a cd to go down fails before it has a
> chance to come back up (or go up and then fail to come back down),
> the later tests will be left in an unexpected place.

I understand this issue with "cd" (I've just followed the existing t7900 tests "code style").

Show 6 quoted lines

> 
> >  contrib/subtree/git-subtree.sh     |   4 +-
> >  contrib/subtree/t/t7900-subtree.sh | 194 +++++++++++++++++++++++--------------
> >  2 files changed, 124 insertions(+), 74 deletions(-)
> 
> Thanks.

-- 
Alexey Shumkin
E-mail: Alex.Crezoff@gmail.com
ICQ: 118001447
Jabber (GoogleTalk): Alex.Crezoff@gmail.com
Skype: crezoff