Re: [PATCH] tag: support mixing --sort=<spec> and -n

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2015, 04:38 UTC
Message-ID: <xmqqoahgb1r9.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAOLa=ZTiG8aMdURDYTHALGfhkg_YWe6bXEmPUySgGBrrQXD+Nw@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 19 quoted lines

> On Sun, Sep 6, 2015 at 3:55 AM, Jacob Keller <jacob.keller@gmail.com> wrote:
>> On Sat, Sep 5, 2015 at 10:52 AM, Rudy Matela <rudy@matela.com.br> wrote:
>>>
>>> Allow -n and --sort=version:refname to be used together
>>> instead of failing with:
>>>
>>>   fatal: --sort and -n are incompatible
>>>
>>> Signed-off-by: Rudy Matela <rudy@matela.com.br>
>>
>> Nice! I've been wondering about this one for a while. Especially since
>> implementing tag.sort configuration which made -n not work at all.
>>
>> Note that it may be worth rebasing this on top of Karthik's part tag
>> to use ref-filter series, since I think there will be plenty of merge
>> conflicts there...
>
> Its already resolved in my series. We use ref-filter's sorting APIs
> there :)

I guess Jacob needs to rebase that tag.sort thing on top of yours, then ;-)?