Re: [PATCH] tag: support mixing --sort=<spec> and -n

From: Jacob Keller <jacob.keller@gmail.com>
Date: Sep 6, 2015, 06:25 UTC
Message-ID: <CA+P7+xqTT2soejXEmpaqfLTF3twWERTLZY6OpW2KdJHS3jxKyQ@mail.gmail.com>
In-Reply-To: <xmqqoahgb1r9.fsf@gitster.mtv.corp.google.com>

On Sat, Sep 5, 2015 at 9:38 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> On Sun, Sep 6, 2015 at 3:55 AM, Jacob Keller <jacob.keller@gmail.com> wrote:
>>> On Sat, Sep 5, 2015 at 10:52 AM, Rudy Matela <rudy@matela.com.br> wrote:
>>>>
>>>> Allow -n and --sort=version:refname to be used together
>>>> instead of failing with:
>>>>
>>>>   fatal: --sort and -n are incompatible
>>>>
>>>> Signed-off-by: Rudy Matela <rudy@matela.com.br>
>>>
>>> Nice! I've been wondering about this one for a while. Especially since
>>> implementing tag.sort configuration which made -n not work at all.
>>>
>>> Note that it may be worth rebasing this on top of Karthik's part tag
>>> to use ref-filter series, since I think there will be plenty of merge
>>> conflicts there...
>>
>> Its already resolved in my series. We use ref-filter's sorting APIs
>> there :)
>
> I guess Jacob needs to rebase that tag.sort thing on top of yours,
> then ;-)?

Ya.. I wasn't sure if this was resolved, and I ended up deciding to wait until after the tag re-write landed to look at that again.

Regards, Jake