git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly"

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 11, 2015, 20:19 UTC
Message-ID
<xmqqoah8zp36.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAPig+cRkSRSC0eaBencw8cFrd64sUBQE44aSJ0T2WyPg2JTFCw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 5 quoted lines
>> +       qz_to_tab_space <<EOF | iconv -f utf-8 -t $test_encoding >expected &&
>
> You don't seem to be taking advantage of qz_to_tab_space's
> transliteration of Q to tab and Z to space, so s/qz_to_tab_space/cat/
> would make the code clearer.

Don't cat into a pipe unless you are concatenating multiple files, though ;-).

Previous: Eric SunshineNext: Josef Kufner
Message 5 of 8 in “Pass graph width to pretty formatting, so '%>|' can work properly”
  1. Pass graph width to pretty formatting, so '%>|' can work properlyJosef Kufner, Sep 11, 2015
  2. Junio C HamanoSep 11, 2015
  3. Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly"Josef Kufner, Sep 11, 2015
  4. Eric SunshineSep 11, 2015
  5. Junio C HamanoSep 11, 2015
  6. Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly"Josef Kufner, Sep 11, 2015
  7. Josef KufnerSep 11, 2015
  8. Josef KufnerSep 11, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.