From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Sep 2015 20:19:09 GMT
Subject: Re: [PATCH] Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly"
Message-ID: <xmqqoah8zp36.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAPig+cRkSRSC0eaBencw8cFrd64sUBQE44aSJ0T2WyPg2JTFCw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

>> +       qz_to_tab_space <<EOF | iconv -f utf-8 -t $test_encoding >expected &&
>
> You don't seem to be taking advantage of qz_to_tab_space's
> transliteration of Q to tab and Z to space, so s/qz_to_tab_space/cat/
> would make the code clearer.

Don't cat into a pipe unless you are concatenating multiple files,
though ;-).