Re: [PATCH 0/3] preparatory patches for the submodule groups

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2016, 21:01 UTC
Message-ID: <xmqqoa8mlutg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kakayOhPkCK4hbRkj-h2Bt+PqD69EgHk-chbu4xCA8_pA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> I have your patch here and have a "-a and pathspec are incompatible" fix
> build on top.
> * I do wonder if we want to have the shortform '-a' though.

I do not particularly care. I was merely matching the other two options there.

> * I think we want to head for consistency, eventually.
>    e.g. commands with no arguments such as tag, branch
>    give a list of their respective domain.

Isn't that a historical mistake we are regretting, though? Only after many other operation modes were invented and "create X" proves not to be the only primary modes we had to invent "tag -l" and "branch -l". Aren't we better off not having "no option means list" kind of default?

>    Subcommands do not give lists by default, e.g.
>    `git stash clear`, `git remote prune`
>    which are the moral equivalent to
>    `git submodule deinit` just work as they were told, no --switch needed.

I wouldn't say "git rm" should remove everything by extending that logic, but I can certainly buy if somebody argues "git submodule deinit" is not destructive enough to warrant extra safety.