Re: [PATCH 1/3] submodule deinit test: fix broken && chain in subshell

From: Stefan Beller <sbeller@google.com>
Date: May 3, 2016, 19:30 UTC
Message-ID: <CAGZ79kZX-UkmTXG=s8qXe-RKynW3Oitk0URZk-K81UOSGfSeEQ@mail.gmail.com>
In-Reply-To: <xmqqvb2vnmh0.fsf@gitster.mtv.corp.google.com>

On Tue, May 3, 2016 at 9:19 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 27 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>  t/t7400-submodule-basic.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
>> index 814ee63..90d80d3 100755
>> --- a/t/t7400-submodule-basic.sh
>> +++ b/t/t7400-submodule-basic.sh
>> @@ -914,7 +914,7 @@ test_expect_success 'submodule deinit works on repository without submodules' '
>>               git init &&
>>               >file &&
>>               git add file &&
>> -             git commit -m "repo should not be empty"
>> +             git commit -m "repo should not be empty" &&
>>               git submodule deinit .
>>       )
>>  '
>
> Thanks.
>
> As this was introduced by 84ba959b (submodule: fix regression for
> deinit without submodules, 2016-03-22), which was merged to the
> mainline at v2.8.0-rc4-8-g2a4c8c3 and applies there, let's queue it
> there.

Ok, I'll reroll there with an improved 2/3 on top of v2.8.0-rc4-8-g2a4c8c3.