git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] i18n: simplify numeric error reporting

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 24, 2016, 15:48 UTC
Message-ID
<xmqqoa4irwwd.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160821145039.12121-3-jn.avila@free.fr>

I'll squash this in to avoid compilation breakage. We do not allow decl-after-stmt.

Thanks.
 config.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/config.c b/config.c
index e33c703..0dfed68 100644
--- a/config.c
+++ b/config.c
@@ -652,10 +652,11 @@ int git_parse_ulong(const char *value, unsigned long *ret)
 NORETURN
 static void die_bad_number(const char *name, const char *value)
 {
+	const char * error_type = (errno == ERANGE)? _("out of range"):_("invalid unit");
+
 	if (!value)
 		value = "";
 
-	const char * error_type = (errno == ERANGE)? _("out of range"):_("invalid unit");
 	if (!(cf && cf->name))
 		die(_("bad numeric config value '%s' for '%s': %s"),
 		    value, name, error_type);
Previous: Jean-Noel AvilaNext: Junio C Hamano
Message 11 of 15 in “[L10N] Kickoff of translation for Git 2.10.0 round 1”
  1. Jiang XinAug 15, 2016
  2. Jean-Noël AVILAAug 20, 2016
  3. Junio C HamanoAug 20, 2016
  4. Jean-Noël AVILAAug 20, 2016
  5. Jiang XinAug 21, 2016
  6. Junio C HamanoAug 23, 2016
  7. Jean-Noël AVILAAug 23, 2016
  8. 1/3 i18n: fix typos for translationJean-Noel Avila, Aug 21, 2016
  9. 2/3 i18n: fix git rebase interactive commit messagesJean-Noel Avila, Aug 21, 2016
  10. 3/3 i18n: simplify numeric error reportingJean-Noel Avila, Aug 21, 2016
  11. Junio C HamanoAug 24, 2016
  12. Junio C HamanoAug 23, 2016
  13. Junio C HamanoAug 24, 2016
  14. Junio C HamanoAug 24, 2016
  15. Alex HenrieAug 25, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.