Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 1, 2017, 18:09 UTC
- Message-ID
- <xmqqo9wguhhn.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170401060116.b2v7tyoi7fcxwbvo@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> On Fri, Mar 31, 2017 at 01:26:31PM -0400, David Turner wrote: > >> Unfortunately, in order to push some large repos, the http postbuffer >> must sometimes exceed two gigabytes. On a 64-bit system, this is OK: >> we just malloc a larger buffer. > > I'm still not sure why a 2GB post-buffer is necessary. It sounds like > something is broken in your setup. Large pushes should be sent chunked. > > I know broken setups are a fact of life, but this feels like a really > hacky work-around.
Yeah, I tend to share that "Huh? We do not want to do this, but what forces us to?" puzzlement.
Tentatively demoted to 'pu' (out of 'jch'--candidates to go to 'next').