git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] Fix a refname trimming problem in `log --bisect`

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 19, 2017, 15:51 UTC
Message-ID
<xmqqo9tkt1qz.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170619091654.vb7krwcmw2y22v7m@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> On Sun, Jun 18, 2017 at 03:39:40PM +0200, Michael Haggerty wrote:
>
>> As before, the second patch is optional. If it is omitted, it might
>> flush out any other bugs like this one in client code. If it is
>> included, regressions are less likely, but we won't learn about other
>> misuses of the API. I have no strong opinion either way.
>
> My feeling is still slightly towards "don't include", but I also don't
> have a strong opinion.

I am inclined to the "don't include 2/2 and cook 1/2 alone but a bit longer" approach.

Thanks, both.
Previous: Jeff KingNext: Jeff King
Message 5 of 6 in “Fix a refname trimming problem in `log --bisect`”
  1. 0/2 Fix a refname trimming problem in `log --bisect`Michael Haggerty, Jun 18, 2017
  2. 1/2 for_each_bisect_ref(): don't trim refnamesMichael Haggerty, Jun 18, 2017
  3. 2/2 prefix_ref_iterator_advance(): relax the check of trim lengthMichael Haggerty, Jun 18, 2017
  4. Jeff KingJun 19, 2017
  5. Junio C HamanoJun 19, 2017
  6. Jeff KingJun 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.