git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config: avoid "write_in_full(fd, buf, len) != len" pattern

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 16, 2017, 05:29 UTC
Message-ID
<xmqqo9o2x04a.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171115124043.17147-1-phillip.wood@talktalk.net>
Phillip Wood <phillip.wood@talktalk.net> writes:
Show 7 quoted lines
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> As explained in commit 06f46f237 (avoid "write_in_full(fd, buf, len)
> != len" pattern, 2017–09–13) the return value of write_in_full() is
> either -1 or the requested number of bytes. As such comparing the
> return value to an unsigned value such as strbuf.len will fail to
> catch errors. Change the code to use the preferred '< 0' check.

Thanks, queued. This seems to have come from 9a5abfc7 ("After renaming a section, print any trailing variable definitions", 2009-07-24), which is rather ancient, but was made worse by getting duplicated by 52d59cc6 ("branch: add a --copy (-c) option to go with --move (-m)", 2017-06-18) recently.

Previous: Phillip WoodNext: Jeff King
Message 2 of 7 in “config: avoid "write_in_full(fd, buf, len) != len" pattern”
  1. config: avoid "write_in_full(fd, buf, len) != len" patternPhillip Wood, Nov 15, 2017
  2. Junio C HamanoNov 16, 2017
  3. Jeff KingNov 17, 2017
  4. René ScharfeNov 18, 2017
  5. Jeff KingNov 18, 2017
  6. René ScharfeNov 18, 2017
  7. Phillip WoodNov 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.