From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 16 Nov 2017 05:29:09 GMT
Subject: Re: [PATCH] config: avoid "write_in_full(fd, buf, len) != len" pattern
Message-ID: <xmqqo9o2x04a.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171115124043.17147-1-phillip.wood@talktalk.net>

Phillip Wood <phillip.wood@talktalk.net> writes:

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> As explained in commit 06f46f237 (avoid "write_in_full(fd, buf, len)
> != len" pattern, 2017–09–13) the return value of write_in_full() is
> either -1 or the requested number of bytes. As such comparing the
> return value to an unsigned value such as strbuf.len will fail to
> catch errors. Change the code to use the preferred '< 0' check.

Thanks, queued.  This seems to have come from 9a5abfc7 ("After
renaming a section, print any trailing variable definitions",
2009-07-24), which is rather ancient, but was made worse by getting
duplicated by 52d59cc6 ("branch: add a --copy (-c) option to go with
--move (-m)", 2017-06-18) recently.