Re: [PATCH 3/3] shortlog: do not accept revisions when run outside repo
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 13, 2018, 21:46 UTC
- Message-ID
- <xmqqo9jr1we3.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <78669e644b64fc10c34adb59717d2039f81cb092.1520680894.git.martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
> in order to decide whether we should read from stdin. (So yes, after > this patch, we will still silently ignore stdin for confused usage such > as `git log v2.15.0.. | git shortlog v2.16.0..`. But at least that does > not crash.)
$ git log -p | git shortlog Documentation/
is also a nonsense request. When outside a repository, i.e.
$ git -C $path_to_repo | git shortlog Documentation/
is not giving any revisions, so the error message should not say "no revisions can be given"---a nitpicky bug reporter would say "I gave no revisions, why are you complaining to me?"