Re: [PATCH 3/3] shortlog: do not accept revisions when run outside repo

From: Martin Ågren <martin.agren@gmail.com>
Date: Mar 14, 2018, 05:06 UTC
Message-ID: <CAN0heSoDSf+3VmRowHmiTPDDzfdvUjQi+tjpPF6RW172ZE5BWw@mail.gmail.com>
In-Reply-To: <xmqqo9jr1we3.fsf@gitster-ct.c.googlers.com>

On 13 March 2018 at 22:46, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Martin Ågren <martin.agren@gmail.com> writes:
>
>> in order to decide whether we should read from stdin. (So yes, after
>> this patch, we will still silently ignore stdin for confused usage such
>> as `git log v2.15.0.. | git shortlog v2.16.0..`. But at least that does
>> not crash.)
>
>     $ git log -p | git shortlog Documentation/
>
> is also a nonsense request.  When outside a repository, i.e.
>
>     $ git -C $path_to_repo | git shortlog Documentation/
>
> is not giving any revisions, so the error message should not say "no
> revisions can be given"---a nitpicky bug reporter would say "I gave
> no revisions, why are you complaining to me?"

Good point. I will see if I can make this similar to other places. Maybe something like "too many arguments given outside repository". Thanks.

Martin