git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 2/2] log: prevent error if line range ends past end of file

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 1, 2018, 01:23 UTC
Message-ID
<xmqqo9gvb8qt.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180531050030.43364-2-istephens@atlassian.com>
istephens@atlassian.com writes:
Show 16 quoted lines
> From: Isabella Stephens <istephens@atlassian.com>
>
> If the -L option is used to specify a line range in git log, and the end
> of the range is past the end of the file, git will fail with a fatal
> error. This commit prevents such behaviour - instead we perform the log
> for existing lines within the specified range.
>
> This commit also fixes a corner case where -L ,-n:file would be treated
> as a log over the whole file. Now we treat this as -L 1,-n:file and
> blame the first line of the file instead.
>
> Signed-off-by: Isabella Stephens <istephens@atlassian.com>
> ---
>  line-log.c          | 8 +++++---
>  t/t4211-line-log.sh | 5 ++---
>  2 files changed, 7 insertions(+), 6 deletions(-)
Thanks.  Will queue.
Previous: istephens@atlassian.comNext: Junio C Hamano
Message 3 of 8 in “blame: prevent error if range ends past end of file”
  1. 1/2 blame: prevent error if range ends past end of fileistephens@atlassian.com, May 31, 2018
  2. 2/2 log: prevent error if line range ends past end of fileistephens@atlassian.com, May 31, 2018
  3. Junio C HamanoJun 1, 2018
  4. Junio C HamanoJun 1, 2018
  5. 1/2 blame: prevent error if range ends past end of fileistephens@atlassian.com, Jun 15, 2018
  6. 2/2 log: prevent error if line range ends past end of fileistephens@atlassian.com, Jun 15, 2018
  7. Isabella StephensJun 15, 2018
  8. Junio C HamanoJun 15, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.