git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 1/2] blame: prevent error if range ends past end of file

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 1, 2018, 01:27 UTC
Message-ID
<xmqqh8mnb8j2.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180531050030.43364-1-istephens@atlassian.com>
istephens@atlassian.com writes:
Show 19 quoted lines
> From: Isabella Stephens <istephens@atlassian.com>
>
> If the -L option is used to specify a line range in git blame, and the
> end of the range is past the end of the file, git will fail with a fatal
> error. This commit prevents such behavior - instead we display the blame
> for existing lines within the specified range. Tests are amended
> accordingly.
>
> This commit also fixes two corner cases. Blaming -L n,-(n+1) now blames
> the first n lines of a file rather than from n to the end of the file.
> Blaming -L ,-n will be treated as -L 1,-n and blame the first line of
> the file, rather than blaming the whole file.
>
> Signed-off-by: Isabella Stephens <istephens@atlassian.com>
> ---
>  builtin/blame.c               |  4 ++--
>  line-range.c                  |  2 +-
>  t/t8003-blame-corner-cases.sh | 12 ++++++++----
>  3 files changed, 11 insertions(+), 7 deletions(-)
Don't t800[12]-*.sh need adjustment for this change, too?
Previous: Junio C HamanoNext: istephens@atlassian.com
Message 4 of 8 in “blame: prevent error if range ends past end of file”
  1. 1/2 blame: prevent error if range ends past end of fileistephens@atlassian.com, May 31, 2018
  2. 2/2 log: prevent error if line range ends past end of fileistephens@atlassian.com, May 31, 2018
  3. Junio C HamanoJun 1, 2018
  4. Junio C HamanoJun 1, 2018
  5. 1/2 blame: prevent error if range ends past end of fileistephens@atlassian.com, Jun 15, 2018
  6. 2/2 log: prevent error if line range ends past end of fileistephens@atlassian.com, Jun 15, 2018
  7. Isabella StephensJun 15, 2018
  8. Junio C HamanoJun 15, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.