git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mailinfo: support format=flowed

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 29, 2018, 20:19 UTC
Message-ID
<xmqqo9dk94vh.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<e2f2ca18-849c-0ef4-98a5-9a1379bfcec5@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 8 quoted lines
> Add best-effort support for patches sent using format=flowed (RFC 3676).
> Remove leading spaces ("unstuff"), remove soft line breaks (indicated
> by space + newline), but leave the signature separator (dash dash space
> newline) alone.
>
> Warn in git am when encountering a format=flowed patch, because any
> trailing spaces would most probably be lost, as the sending MUA is
> encouraged to remove them when preparing the email.

The warning is a very good idea, but I wonder if it is loud enough when mixed with other noise (e.g. "--whitespace=warn" for a short series, or patch titles when applying a very long series).

Lossage of trailing spaces may even be a feature (just joking), when the project policy makes it OK to use "am --whitespace=fix". I usually use "am --whitespace=fix" but I used "am --whitespace=warn" while applying this patch to preserve lines that begin with "SP SP HT" in the sample patch.

Previous: René ScharfeNext: Jonathan Nieder
Message 2 of 4 in “mailinfo: support format=flowed”
  1. mailinfo: support format=flowedRené Scharfe, Aug 25, 2018
  2. Junio C HamanoAug 29, 2018
  3. Jonathan NiederSep 4, 2018
  4. Jonathan NiederSep 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.