Re: [PATCH] mailinfo: support format=flowed

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 4, 2018, 23:25 UTC
Message-ID: <20180904232542.GC34268@aiede.svl.corp.google.com>
In-Reply-To: <20180904231959.GB34268@aiede.svl.corp.google.com>

Jonathan Nieder wrote:

> René Scharfe wrote:

Show 26 quoted lines

>>  builtin/am.c                |    4 +
>>  mailinfo.c                  |   64 +-
>>  mailinfo.h                  |    2 +
>>  t/t4256-am-format-flowed.sh |   19 +
>>  t/t4256/1/mailinfo.c        | 1245 +++++++++++++++++++++++++++++++++++
>>  t/t4256/1/mailinfo.c.orig   | 1185 +++++++++++++++++++++++++++++++++
>
> This mailinfo.c.orig file appears to have been lost when applying the
> patch to git.git, resulting in test failures:
>
>  $ ./t4256-am-format-flowed.sh -v -i
>  Initialized empty Git repository in git/t/trash directory.t4256-am-format-flowed/.git/
>  expecting success: 
>         cp "$TEST_DIRECTORY/t4256/1/mailinfo.c.orig" mailinfo.c &&
>         git add mailinfo.c &&
>         git commit -m initial
>
>  cp: cannot stat 'git/t/t4256/1/mailinfo.c.orig': No such file or directory
>  not ok 1 - setup
>  #
>  #               cp "$TEST_DIRECTORY/t4256/1/mailinfo.c.orig" mailinfo.c &&
>  #               git add mailinfo.c &&
>  #               git commit -m initial
>  #
>
> Known issue?

My bad: this was operator error:

 $ git status -s
  D t/t4256/1/mailinfo.c.orig

The issue was that I ran dh_clean, which removed the .orig file. I'll fix the issue on my side. Sorry for the false alarm.

Sincerely, Jonathan