Re: [PATCH v3 0/4] remove extern from function declarations

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2019, 05:28 UTC
Message-ID: <xmqqo94hsc63.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190503174503.GA8242@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I think spatch is smart enough not to hit the same header multiple
> times. But the problem is that we invoke it once per file, so it
> actually processes cache.h many times. That's slow, but also produces
> bogus patches.

Yes, I've seen this and was a bit irritated myself, but not enough to do something about it myself, yet.

>
> Jacob Keller's patches to collapse this to a single invocation do fix it
> (and I've used them selectively in the past rather than cleaning up the
> resulting patch manually ;) ).

Ah, that is nice to know.  Do we want to resurrect it?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.