Re: [PATCH v2 0/4] Makefile/coccicheck: fix bugs and speed it up

From: René Scharfe. <l.s.r@web.de>
Date: Mar 13, 2021, 16:10 UTC
Message-ID: <778c6cd8-b1c4-2a97-ab09-a926196ab0b0@web.de>
In-Reply-To: <xmqqft16914r.fsf@gitster.c.googlers.com>

Am 07.03.21 um 21:09 schrieb Junio C Hamano:

Show 6 quoted lines

> René Scharfe. <l.s.r@web.de> writes:
>> Anyway, what about this more targeted approach:
>
> It is a targetted approach to solve a different problem from the
> original one.  I like the solution and the resulting code, but I
> also like the solution to the original problem, too ;-)

We can have both. :) The semantic patch for correcting the argument order of xcalloc calls allows the one for using CALLOC_ARRAY to be simplified, as it doesn't have to do that normalization itself.

I can't bring myself to introduce special macros for allocating a single object. Let's first make use what we already have.

René

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.