git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Patch v2 0/2] Replace strbuf_write_fd with write_in_full

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 19, 2020, 20:51 UTC
Message-ID
<xmqqo8peg4o4.fsf@gitster.c.googlers.com>
In-Reply-To
<20200619202320.4619-1-randall.s.becker@rogers.com>
randall.s.becker@rogers.com writes:
Show 7 quoted lines
> From: "Randall S. Becker" <randall.becker@nexbridge.ca>
>
> The strbuf_write_fd method does not check whether the buffer exceeds
> MAX_IO_SIZE on the target platform. This fix replaces the use of that
> method with write_in_full, which does. Since this is the only use of
> strbuf_write_fd, and since the method was unsafe, it has been removed
> from strbuf.c and strbuf.h.
Excellent.  Thanks.
Will queue.
Previous: randall.s.becker@rogers.com
Message 4 of 4 in “Replace strbuf_write_fd with write_in_full”
  1. 0/2 Replace strbuf_write_fd with write_in_fullrandall.s.becker@rogers.com, Jun 19, 2020
  2. 1/2 bugreport.c: replace strbuf_write_fd with write_in_fullrandall.s.becker@rogers.com, Jun 19, 2020
  3. 2/2 strbuf: remove unreferenced strbuf_write_fd method.randall.s.becker@rogers.com, Jun 19, 2020
  4. Junio C HamanoJun 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.