From: Junio C Hamano Date: Fri, 19 Jun 2020 20:51:39 GMT Subject: Re: [Patch v2 0/2] Replace strbuf_write_fd with write_in_full Message-ID: In-Reply-To: <20200619202320.4619-1-randall.s.becker@rogers.com> randall.s.becker@rogers.com writes: > From: "Randall S. Becker" > > The strbuf_write_fd method does not check whether the buffer exceeds > MAX_IO_SIZE on the target platform. This fix replaces the use of that > method with write_in_full, which does. Since this is the only use of > strbuf_write_fd, and since the method was unsafe, it has been removed > from strbuf.c and strbuf.h. Excellent. Thanks. Will queue.