git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch-pack: in partial clone, pass --promisor

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 21, 2020, 21:42 UTC
Message-ID
<xmqqo8n37k1z.fsf@gitster.c.googlers.com>
In-Reply-To
<20200821210827.1203531-1-jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 13 quoted lines
>> Jonathan Tan <jonathantanmy@google.com> writes:
>> 
>> > When fetching a pack from a promisor remote, the corresponding .promisor
>> > file needs to be created. "fetch-pack" originally did this by passing
>> > "--promisor" to "index-pack", but in 5374a290aa ("fetch-pack: write
>> > fetched refs to .promisor", 2019-10-16), "fetch-pack" was taught to do
>> > this itself instead, because it needed to store ref information in the
>> > .promisor file.
>> 
>> So is this patch a fix for a regression in v2.25?
>
> Yes. (Just checked with "git merge-base" that 5374a290aa is in v2.25.0
> but not v2.24.0.)
Thanks.

I wonder how we missed the breakage back then, but better late than never ;-)

Previous: Jonathan Tan
Message 4 of 4 in “fetch-pack: in partial clone, pass --promisor”
  1. fetch-pack: in partial clone, pass --promisorJonathan Tan, Aug 20, 2020
  2. Junio C HamanoAug 20, 2020
  3. Jonathan TanAug 21, 2020
  4. Junio C HamanoAug 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.