From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 21 Aug 2020 21:42:16 GMT
Subject: Re: [PATCH] fetch-pack: in partial clone, pass --promisor
Message-ID: <xmqqo8n37k1z.fsf@gitster.c.googlers.com>
In-Reply-To: <20200821210827.1203531-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> Jonathan Tan <jonathantanmy@google.com> writes:
>> 
>> > When fetching a pack from a promisor remote, the corresponding .promisor
>> > file needs to be created. "fetch-pack" originally did this by passing
>> > "--promisor" to "index-pack", but in 5374a290aa ("fetch-pack: write
>> > fetched refs to .promisor", 2019-10-16), "fetch-pack" was taught to do
>> > this itself instead, because it needed to store ref information in the
>> > .promisor file.
>> 
>> So is this patch a fix for a regression in v2.25?
>
> Yes. (Just checked with "git merge-base" that 5374a290aa is in v2.25.0
> but not v2.24.0.)

Thanks.  

I wonder how we missed the breakage back then, but better late than
never ;-)