Re: What's cooking in git.git (Aug 2020, #07; Thu, 27)

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 28, 2020, 20:51 UTC
Message-ID: <xmqqo8muo5nt.fsf@gitster.c.googlers.com>
In-Reply-To: <CA+CkUQ_=qm2x2zKvgHnvKLLA_A23gTNm8Q8CeWxLFGSBi=9gKw@mail.gmail.com>

Hariom verma <hariom18599@gmail.com> writes:

Show 20 quoted lines

>> * hv/ref-filter-misc (2020-08-17) 9 commits
>>   (merged to 'next' on 2020-08-27 at c015fa6b0f)
>>  + ref-filter: add `sanitize` option for 'subject' atom
>>  + format-support: move `format_sanitized_subject()` from pretty
>>  + pretty: refactor `format_sanitized_subject()`
>>  + ref-filter: add `short` modifier to 'parent' atom
>>  + ref-filter: add `short` modifier to 'tree' atom
>>  + ref-filter: rename `objectname` related functions and fields
>>  + ref-filter: modify error messages in `grab_objectname()`
>>  + ref-filter: refactor `grab_objectname()`
>>  + ref-filter: support different email formats
>>
>>  The "--format=" option to the "for-each-ref" command and friends
>>  learned a few more tricks, e.g. the ":short" suffix that applies to
>>  "objectname" now also can be used for "parent", "tree", etc.
>>
>>  Will merge to 'master'.
>
> I sent an updated version of the patch series addressing your comment
> concerning new file format-support.{c,h}[1].

Yikes, my mistake. As long as you plan to vastly extend what would be in format-support.[ch], I do not mind to have a pair of separate files in the end, by the time when we have, say, unified "--format" support for for-each-ref family (e.g. "%(token)") and log family (e.g. "%x" fixed few letter combinations). So the step that moves some from pretty.c to format-support.c does not bother me all that much. It just felt unnecessary within the scope of this series.

But other stuff (like format-sanitized-subject having unnecessary allocation and unnecessary special casing of LF) are worth fixing in the version queued above.

Thanks for stopping me.

Let's revert the above out of 'next' and start afresh using v4.