Re: What's cooking in git.git (Aug 2020, #07; Thu, 27)

From: Hariom verma <hariom18599@gmail.com>
Date: Aug 29, 2020, 10:13 UTC
Message-ID: <CA+CkUQ-SsxrJk+7e-ygm8FfCto6XZt2Ts9UcTMpgkmAQWZkLhA@mail.gmail.com>
In-Reply-To: <xmqqh7snpxy1.fsf@gitster.c.googlers.com>

Hi,

On Fri, Aug 28, 2020 at 3:14 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

>
> [Cooking]
>
> * hv/ref-filter-trailers-atom-parsing-fix (2020-08-21) 2 commits
>   (merged to 'next' on 2020-08-24 at 79b27f3263)
>  + ref-filter: 'contents:trailers' show error if `:` is missing
>  + t6300: unify %(trailers) and %(contents:trailers) tests
>
>  The parser for "git for-each-ref --format=..." was too loose when
>  parsing the "%(trailers...)" atom, and forgot that "trailers" and
>  "trailers:<modifers>" are the only two allowed forms, which has
>  been corrected.
>
>  Will merge to 'master'.
>

After a discussion, we agreed on keeping the helper function instead on duplicating code in "ref-filter: 'contents:trailers' show error if `:` is missing" There is a high possibility we might want to reuse helper in other places too. Especially in the case of newly added "%(subject:sanitize)", if we also want "%(contents:subject:sanitize)" to work.

Full discussion: https://public-inbox.org/git/CA+CkUQ8Gst2RTaXY6t+ytWu_9Pu7eqnRYRrnawRwYd_NN=u0Lg@mail.gmail.com/

I'm about to send the updated patch series soon.

Thanks, Hariom