Re: Bug report: orphaned pack-objects after killing upload-pack on [

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2020, 01:04 UTC
Message-ID: <xmqqo8jllyhc.fsf@gitster.c.googlers.com>
In-Reply-To: <X778eIAr3uzdh0H0@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> On Wed, Nov 25, 2020 at 01:42:24PM -0800, Junio C Hamano wrote:
>
>> In the meantime, I may queue this on 'seen' but it cannot move
>> forward without a signoff.
>>  ...
>   We spawn an external pack-objects process to actually send objects to
>   the remote side. If we are killed by a signal during this process,
>   then pack-objects may continue to run. As soon as it starts producing
>   output for the pack, it will see a failure writing to upload-pack and
>   exit itself. But before then, it may do significant work traversing
>   the object graph, compressing deltas, etc, which will all be
>   pointless. So let's make sure to kill as soon as we know that the
>   caller will not read the result.

Thanks, that reads well.