Re: Bug report: orphaned pack-objects after killing upload-pack on [

From: Jeff King <peff@peff.net>
Date: Nov 24, 2020, 09:11 UTC
Message-ID: <X7zOKbzR9gwJHMbJ@coredump.intra.peff.net>
In-Reply-To: <xmqqd006s7ee.fsf@gitster.c.googlers.com>

On Sat, Nov 21, 2020 at 01:54:17PM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> > I wrote this patch ages ago, and it is still sitting close to the bottom
> > (if not the bottom) of my todo stack, waiting to be investigated. ;)
> 
> Sounds sensible.
> 
> > -- >8 --
> > Subject: [PATCH] send-pack: kill pack-objects helper on signal or exit

Looks like you picked up this patch on a topic branch

I was thinking of polishing it further with a test, but I can't think of a good way to do one that would not be horribly racy. I even tried to think of a racy test I could run manually (e.g., pushing and killing in a loop) but even that is tough (even with the patch, it's racy whether the push will succeed or not, depending on exactly when you kill the parent, so there's no automatic way to distinguish the improved cases).

So I think it is still a good idea to do, and what I wrote earlier is as good a we can do.

René, do you want to wrap up your similar patch for the fetch side?

-Peff