git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] rebase: add a config option for --no-fork-point

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 23, 2021, 08:21 UTC
Message-ID
<xmqqo8gb42kb.fsf@gitster.g>
In-Reply-To
<YDSvhEBh8YeCblpa@generichostname>
Denton Liu <liu.denton@gmail.com> writes:
> I don't think this test is quite necessary. In other parts of the
> code, we've already tested that local configs have priority over
> global configs. We can assume that config machinery works so we
> don't need to test it here.

I am not so sure if we should place so much trust in the code of "rebase", or any other subsystem for that matter, that it uses the configuration API and parse-options API correctly.

The do_test_rebase helper introduced here would be useful clean-up on its own, so I'd rather take it as-is.

Previous: Denton LiuNext: Martin Ågren
Message 3 of 7 in “rebase: add a config option for --no-fork-point”
  1. rebase: add a config option for --no-fork-pointAlex Henrie, Feb 23, 2021
  2. Denton LiuFeb 23, 2021
  3. Junio C HamanoFeb 23, 2021
  4. Martin ÅgrenFeb 24, 2021
  5. Martin ÅgrenFeb 24, 2021
  6. Junio C HamanoFeb 24, 2021
  7. Alex HenrieFeb 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.